mkatanbaf commented on PR #13051: URL: https://github.com/apache/tvm/pull/13051#issuecomment-1276970012
> * Would it make sense to create an even-more-abstract class that handled graph creation and running for all the tests in this directory, not just the `conv2d` variants? When I was working on adding corstone to the platforms supported by the project API, we talked about migrating from this test structure and use Project API for these tests too. But then the fvp transport layer was not as stable as we have hoped for, and we didn't continue that work at that time. One argument in favor of creating a more abstract class is that it makes it easier to change the test structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
