adstraw commented on code in PR #13111: URL: https://github.com/apache/tvm/pull/13111#discussion_r999606319
########## src/runtime/hexagon/hexagon_hvx.h: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef TVM_RUNTIME_HEXAGON_HEXAGON_HVX_H_ +#define TVM_RUNTIME_HEXAGON_HEXAGON_HVX_H_ + +namespace tvm { +namespace runtime { +namespace hexagon { + +class HexagonHvx { + public: + //! \brief Constructor. + // TODO(HWE): Pass in a parameter for which HVX instance to bind + HexagonHvx(); + + //! \brief Destructor. + ~HexagonHvx(); + + //! \brief Prevent copy construction of HexagonHvx. + HexagonHvx(const HexagonHvx&) = delete; + + //! \brief Prevent copy assignment with HexagonHvx. + HexagonHvx& operator=(const HexagonHvx&) = delete; + + //! \brief Prevent move construction. + HexagonHvx(HexagonHvx&&) = delete; + + //! \brief Prevent move assignment. + HexagonHvx& operator=(HexagonHvx&&) = delete; + + private: Review Comment: Looks like this can be deleted. No private members / methods. ########## tests/cpp-runtime/hexagon/hexagon_thread_manager_tests.cc: ########## @@ -28,15 +29,15 @@ using namespace tvm::runtime::hexagon; class HexagonThreadManagerTest : public ::testing::Test { protected: void SetUp() override { - htm = new HexagonThreadManager(threads, stack_size, pipe_size); + htm = HexagonDeviceAPI::Global()->ThreadManager(); streams = htm->GetStreamHandles(); } - void TearDown() override { delete htm; } + void TearDown() override {} HexagonThreadManager* htm{nullptr}; std::vector<TVMStreamHandle> streams; int answer{0}; const unsigned threads{6}; - const unsigned pipe_size{100}; + const unsigned pipe_size{1000}; Review Comment: We might add a "getter" for the pipe size and stack size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
