tqchen commented on code in PR #15140: URL: https://github.com/apache/tvm/pull/15140#discussion_r1238893177
########## tests/python/relax/test_tvmscript_printer_relax.py: ########## @@ -47,8 +47,10 @@ def main(a: R.Tensor((10, 10))) -> R.Tensor((10, 10)): def test_extern_func(): + # note: this function will be treated as private unless a global symbol is added Review Comment: likely we don;t need such detection? since @R.function itself implies a public function by default i assume and we would need explicit `private=True` flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
