slyubomirsky commented on code in PR #15140: URL: https://github.com/apache/tvm/pull/15140#discussion_r1239034785
########## tests/python/relax/test_tvmscript_printer_relax.py: ########## @@ -47,8 +47,10 @@ def main(a: R.Tensor((10, 10))) -> R.Tensor((10, 10)): def test_extern_func(): + # note: this function will be treated as private unless a global symbol is added Review Comment: We don't want to put a global symbol on inner functions (I assume), so that's why the current behavior is to make sure that the function is inside an IRModule. I think I can detect this case in `entry.py`, however. It might be a little hacky, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
