(incubator-uniffle) branch master updated: [#2356] Improvement: Fix the warning: unchecked call to put(E) as a member of the raw type RMRecordsReader.Queue (#2357)

[roryqi]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 124a90158 [#2356] Improvement: Fix the warning: unchecked call to 
put(E) as a member of the raw type RMRecordsReader.Queue (#2357)
124a90158 is described below

commit 124a9015835bf30e47bb16d584b065bea06f01e9
Author: Neo Chien <cchung1...@cs.ccu.edu.tw>
AuthorDate: Thu Feb 13 11:32:00 2025 +0800

    [#2356] Improvement: Fix the warning: unchecked call to put(E) as a member 
of the raw type RMRecordsReader.Queue (#2357)
    
    ### What changes were proposed in this pull request?
    Fix the warning: unchecked call to put(E) as a member of the raw type 
RMRecordsReader.Queue
    
    ### Why are the changes needed?
    Fix: #2356
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    current UT
    <img width="1397" alt="image" 
src="https://github.com/user-attachments/assets/b80755db-d74e-42af-932b-72c955ed5086";
 />
---
 .../org/apache/uniffle/client/record/reader/RMRecordsReader.java | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/client/src/main/java/org/apache/uniffle/client/record/reader/RMRecordsReader.java
 
b/client/src/main/java/org/apache/uniffle/client/record/reader/RMRecordsReader.java
index 311768d64..11f6fc6a1 100644
--- 
a/client/src/main/java/org/apache/uniffle/client/record/reader/RMRecordsReader.java
+++ 
b/client/src/main/java/org/apache/uniffle/client/record/reader/RMRecordsReader.java
@@ -180,7 +180,8 @@ public class RMRecordsReader<K, V, C> {
     this.maxBufferPerPartition = Math.max(1, maxBuffer / partitionIds.size());
     this.maxRecordsNumPerBuffer =
         rssConf.get(RSS_CLIENT_REMOTE_MERGE_READER_MAX_RECORDS_PER_BUFFER);
-    this.results = new Queue(maxBufferPerPartition * maxRecordsNumPerBuffer * 
partitionIds.size());
+    this.results =
+        new Queue<>(maxBufferPerPartition * maxRecordsNumPerBuffer * 
partitionIds.size());
     this.retryMax =
         rssConf.getInteger(
             RssClientConfig.RSS_CLIENT_RETRY_MAX,
@@ -400,7 +401,7 @@ public class RMRecordsReader<K, V, C> {
     private volatile boolean producerDone = false;
 
     Queue(int maxBufferPerPartition) {
-      this.queue = new LinkedBlockingQueue(maxBufferPerPartition);
+      this.queue = new LinkedBlockingQueue<>(maxBufferPerPartition);
     }
 
     public void setProducerDone(boolean producerDone) {
@@ -438,7 +439,7 @@ public class RMRecordsReader<K, V, C> {
     private long sleepTime;
     private long blockId = 1; // Merged blockId counting from 1
     private RecordBuffer recordBuffer;
-    private Queue nextQueue;
+    private Queue<RecordBuffer> nextQueue;
     private List<ShuffleServerInfo> serverInfos;
     private ShuffleServerClient client;
     private int choose;
@@ -561,7 +562,7 @@ public class RMRecordsReader<K, V, C> {
     // distributed in different RecordBuffers. So we need a cachedBuffer used
     // to record the buffer of the last combine.
     private RecordBuffer cached;
-    private Queue nextQueue;
+    private Queue<RecordBuffer> nextQueue;
 
     RecordsCombiner(int partitionId) {
       this.partitionId = partitionId;