This is an automated email from the ASF dual-hosted git repository.
zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new e2523ec0b improvement(client): Simplify skipping processed blockIds
check to speed up (#2368)
e2523ec0b is described below
commit e2523ec0b853dfc68985bd264aa10c03963a44cc
Author: Junfan Zhang <[email protected]>
AuthorDate: Fri Feb 14 19:18:50 2025 +0800
improvement(client): Simplify skipping processed blockIds check to speed up
(#2368)
### What changes were proposed in this pull request?
Use the `andNot` to replace `or` and `xor`
### Why are the changes needed?
To speed up
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests
---
Co-authored-by: Junfan Zhang <[email protected]>
---
.../apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java
b/storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java
index ae45a7505..700e99f93 100644
---
a/storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java
+++
b/storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java
@@ -96,8 +96,7 @@ public abstract class DataSkippableReadHandler extends
PrefetchableClientReadHan
blocksOfSegment.and(expectBlockIds);
if (!blocksOfSegment.isEmpty()) {
// skip processed blockIds
- blocksOfSegment.or(processBlockIds);
- blocksOfSegment.xor(processBlockIds);
+ blocksOfSegment.andNot(processBlockIds);
if (!blocksOfSegment.isEmpty()) {
result = readShuffleData(segment);
segmentIndex++;