kamir commented on code in PR #652: URL: https://github.com/apache/wayang/pull/652#discussion_r2669023760
########## wayang-platforms/wayang-jdbc-template/src/main/java/org/apache/wayang/jdbc/operators/JdbcJoinOperator.java: ########## Review Comment: I think the problem was in the test class: SELECT * FROM **testA** JOIN **testA** ON testB.a=testA.a; In [JdbcJoinOperator.java](https://github.com/apache/wayang/pull/652/changes#diff-daca6094ef619463d8bbaa8ec264dc4723b92352f4646de638478f642c7cbc47) the code looks good. ########## wayang-platforms/wayang-jdbc-template/src/main/java/org/apache/wayang/jdbc/operators/JdbcJoinOperator.java: ########## @@ -73,7 +73,7 @@ public String createSqlClause(Connection connection, FunctionCompiler compiler) final String rightTableName = right.field0; final String rightKey = right.field1; - return "JOIN " + leftTableName + " ON " + + return "JOIN " + rightTableName + " ON " + Review Comment: ```suggestion return "JOIN " + leftTableName + " ON " + ``` I think this is wrong and not needed. Just fix the test case where the assertion has teh same tablename twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
