zkaoudi commented on PR #652:
URL: https://github.com/apache/wayang/pull/652#issuecomment-3724099252

   +1 for this PR. 
   The left table is created as a "FROM $leftTableName" statement in the source 
operator. In the proposed change the "JOIN" should be done on the right table 
as a string of "JOIN $rightTableName". Then the equality "ON" comes where it 
doesn't matter the order of the predicates.
   
   @treyfel maybe you can split up the return string into two strings  (join 
part and predicates part) so that it's not confusing with a single return 
statement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to