Component registers feedback messages badly
-------------------------------------------
Key: WICKET-2871
URL: https://issues.apache.org/jira/browse/WICKET-2871
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.8, 1.4.7, 1.4.6, 1.4.5, 1.4.4, 1.4.3, 1.4.2, 1.4.1,
1.4.0
Environment: Windows 7
Wicket 1.4.7
Reporter: Hielke Hoeve
Priority: Trivial
Attachments: Session.patch
Component registers feedback messages by adding them to the FeedbackMessages
class directly while there are special functions in Session to do this.
Component should call Session.get().error(message) in the following example. I
have attached a patch file which fixes this.
Example:
Component.class
public final void error(final Serializable message)
{
Session.get().getFeedbackMessages().error(this, message);
Session.get().dirty();
}
Session.class:
public final void error(final String message)
{
addFeedbackMessage(message, FeedbackMessage.ERROR);
}
private void addFeedbackMessage(String message, int level)
{
getFeedbackMessages().add(null, message, level);
dirty();
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
