[
https://issues.apache.org/jira/browse/WICKET-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867939#action_12867939
]
Jeremy Thomerson commented on WICKET-2871:
------------------------------------------
Hielke,
Did you read the third point, where it says "BIGGEST PROBLEM"? Your patch is
broken. It breaks stuff. Stuff will fail to work. A major feature would be
totally disabled. Please re-read that portion of my original post, then try it
out in the quickstart to understand what I'm talking about (if you have not
used this feature before, which it appears you have not).
Your comment says "it still breaks the tests" - that's a good indication that
your patch breaks stuff. It's why I asked you to run the tests before
submitting a patch. When a test breaks, you should look at the test, see
what's it's doing, and try to understand whether you're breaking functionality,
or if it's a poorly written test. Most of the time, it will mean that you are
breaking functionality.
Regarding your PS - rather than thinking that we are making some mistake,
please try to understand why the two locations use two different APIs. This is
explained in my first post, point three.
> Component registers feedback messages badly
> -------------------------------------------
>
> Key: WICKET-2871
> URL: https://issues.apache.org/jira/browse/WICKET-2871
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7,
> 1.4.8
> Environment: Windows 7
> Wicket 1.4.7
> Reporter: Hielke Hoeve
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Attachments: Session.patch, wicket-2871.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Component registers feedback messages by adding them to the FeedbackMessages
> class directly while there are special functions in Session to do this.
> Component should call Session.get().error(message) in the following example.
> I have attached a patch file which fixes this.
> Example:
> Component.class
> public final void error(final Serializable message)
> {
> Session.get().getFeedbackMessages().error(this, message);
> Session.get().dirty();
> }
> Session.class:
> public final void error(final String message)
> {
> addFeedbackMessage(message, FeedbackMessage.ERROR);
> }
> private void addFeedbackMessage(String message, int level)
> {
> getFeedbackMessages().add(null, message, level);
> dirty();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
