[ 
https://issues.apache.org/jira/browse/WICKET-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068536#comment-14068536
 ] 

Martin Grigorov commented on WICKET-5648:
-----------------------------------------

What if you want to read the cookie value in JavaScript ?
Then you need to decode it there manually. But first you will need to check 
what Wicket does at the server side...

I see your point but I don't see a stable solution...

> CookieUtils - add #loadValues(), make #getCookie() public, properly 
> initialize from the defaults
> ------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5648
>                 URL: https://issues.apache.org/jira/browse/WICKET-5648
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Thibault Kruse
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 7.0.0-M3, 6.17.0
>
>
> Hi, not sure even whether CookieUtils is supposed to be used outside wicket. 
> But if so, it has some API flaws.
> The CookieUtils class has 
> public final void save(String key, final String... values)
> but no *public* load method to load the saved multiple values. Clients can 
> load the whole string and split themselves, but that's dirty. And using 
> FormComponent.VALUE_SEPARATOR seems wicket-specific anyway (and is not safe 
> against values with that separator), so maybe that method should be 
> protected, not public.
> The code
> cookie.setSecure(false);
> in save() also seems dodgy, but seems to have no effect (defaultSettings 
> still work).
> Finally it is a bit weird that there is no access to the underlying Cookie 
> itself, with it's getDomain() etc methods. For Developers it might be nice to 
> work with the cookie avoiding the boilerplate code, so maybe getCookie() 
> could be made public instead of private



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to