[
https://issues.apache.org/jira/browse/WICKET-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084511#comment-14084511
]
ASF subversion and git services commented on WICKET-5648:
---------------------------------------------------------
Commit 89ce5c41be76ea7a7c9c4679e419c15d83aaed07 in wicket's branch
refs/heads/wicket-6.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=89ce5c4 ]
WICKET-5648 CookieUtils - add #loadValues(), make #getCookie() public, properly
initialize from the defaults
Remove the newly introduced CookieUtils#loadValues() method.
At http://markmail.org/message/6t5gaeb3c2h24r36 we decided to deprecate all
multivalue related methods in 6.x and remove them in 7.x
> CookieUtils - add #loadValues(), make #getCookie() public, properly
> initialize from the defaults
> ------------------------------------------------------------------------------------------------
>
> Key: WICKET-5648
> URL: https://issues.apache.org/jira/browse/WICKET-5648
> Project: Wicket
> Issue Type: Improvement
> Reporter: Thibault Kruse
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 7.0.0-M3, 6.17.0
>
>
> Hi, not sure even whether CookieUtils is supposed to be used outside wicket.
> But if so, it has some API flaws.
> The CookieUtils class has
> public final void save(String key, final String... values)
> but no *public* load method to load the saved multiple values. Clients can
> load the whole string and split themselves, but that's dirty. And using
> FormComponent.VALUE_SEPARATOR seems wicket-specific anyway (and is not safe
> against values with that separator), so maybe that method should be
> protected, not public.
> The code
> cookie.setSecure(false);
> in save() also seems dodgy, but seems to have no effect (defaultSettings
> still work).
> Finally it is a bit weird that there is no access to the underlying Cookie
> itself, with it's getDomain() etc methods. For Developers it might be nice to
> work with the cookie avoiding the boilerplate code, so maybe getCookie()
> could be made public instead of private
--
This message was sent by Atlassian JIRA
(v6.2#6252)
