[ https://issues.apache.org/jira/browse/WICKET-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041561#comment-15041561 ]
ASF GitHub Bot commented on WICKET-6042: ---------------------------------------- Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/143#discussion_r46681742 --- Diff: wicket-core/src/main/java/org/apache/wicket/markup/html/image/Image.java --- @@ -316,8 +316,9 @@ public void setXValues(String... values) if (xValues == null) { xValues = new ArrayList<>(); + }else{ --- End diff -- Empty space after `{` and `else` should be on new line. Is Eclipse formatter broken or what ? ;-) > Implementation of ExternalImage component > ----------------------------------------- > > Key: WICKET-6042 > URL: https://issues.apache.org/jira/browse/WICKET-6042 > Project: Wicket > Issue Type: Improvement > Components: wicket > Affects Versions: 7.1.0, 8.0.0-M1 > Reporter: Tobias Soloschenko > Assignee: Tobias Soloschenko > Labels: features > > Like in the MediaComponent - Video for example > (https://ci.apache.org/projects/wicket/apidocs/7.x/org/apache/wicket/markup/html/media/video/Video.html) > the Image should be able to be configured with a String placed into the src > attribute. > Possible constructor to be used for that: > Image(String id, IModel<?> model, String... srcs) > As of comments the requirement changed a bit and a new implementation > "ExternalImage" is the target of this ticket: > http://apache-wicket.1842946.n4.nabble.com/Image-based-on-external-url-model-object-tt4672692.html#none -- This message was sent by Atlassian JIRA (v6.3.4#6332)