[
https://issues.apache.org/jira/browse/WICKET-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041564#comment-15041564
]
ASF GitHub Bot commented on WICKET-6042:
----------------------------------------
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/143#discussion_r46681825
--- Diff:
wicket-core/src/test/java/org/apache/wicket/markup/html/image/ExternalImageTest.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.markup.html.image;
+
+import java.io.Serializable;
+import java.util.List;
+
+import org.apache.wicket.Component;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.util.tester.TagTester;
+import org.apache.wicket.util.tester.WicketTestCase;
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Test cases to test the external image components
+ *
+ * @author Tobias Soloschenko
+ *
+ */
+public class ExternalImageTest extends WicketTestCase
--- End diff --
Would be good to have a test verifying that CompoundPropertyModel actually
works for ExternalImage!
> Implementation of ExternalImage component
> -----------------------------------------
>
> Key: WICKET-6042
> URL: https://issues.apache.org/jira/browse/WICKET-6042
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 7.1.0, 8.0.0-M1
> Reporter: Tobias Soloschenko
> Assignee: Tobias Soloschenko
> Labels: features
>
> Like in the MediaComponent - Video for example
> (https://ci.apache.org/projects/wicket/apidocs/7.x/org/apache/wicket/markup/html/media/video/Video.html)
> the Image should be able to be configured with a String placed into the src
> attribute.
> Possible constructor to be used for that:
> Image(String id, IModel<?> model, String... srcs)
> As of comments the requirement changed a bit and a new implementation
> "ExternalImage" is the target of this ticket:
> http://apache-wicket.1842946.n4.nabble.com/Image-based-on-external-url-model-object-tt4672692.html#none
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
