solomax commented on code in PR #509: URL: https://github.com/apache/wicket/pull/509#discussion_r843422043
########## wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java: ########## @@ -97,6 +128,36 @@ public void push(byte[] message, int offset, int length) } } + @Override + public Future<Void> pushAsync(byte[] message, int offset, int length) Review Comment: I would replace this method with `return pushAsync(message, offset, length, -1)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org