solomax commented on code in PR #509: URL: https://github.com/apache/wicket/pull/509#discussion_r843423501
########## wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java: ########## @@ -189,7 +189,20 @@ private void process(final Application application, final Collection<IWebSocketC @Override public void run() { - wsConnection.sendMessage(message); + if (webSocketSettings.isAsynchronousPush()) + { + if (webSocketSettings.getAsynchronousPushTimeout() > 0) Review Comment: I would drop this `if` and call the function with `timeout` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org