[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605928#comment-17605928
]
Daniel Stoch commented on WICKET-6999:
--------------------------------------
I have investigated this a little bit further. I think the problem is in
wicket-parent pom.xml in maven-bundle-plugin configuration. Everything works
fine in older Wicket versions (6.x, 7.x) with this plugin version 2.3.7. In
newer Wicket versions there are newer versions of that plugin and its behavior
has probably changed.
When <configuration> section is defined under <executions>/<execution> then it
is simply not used by this plugin so the default settings are used! I moved
configuration on the top level of this plugin definition then it starts to work.
But now:
{noformat}
<Export-Package>*</Export-Package>
{noformat}
causes wrong behaviour: not only wicket.* packages are exported but also some
3rd party ones. I not found a correct settings yet.
In general this should also fix a problem from WICKET-6958 because slf4j
packages were removed from Import-Package section. Probably because of:
{noformat}
<DynamicImport-Package>*</DynamicImport-Package>
{noformat}
which in general is not a good practice in OSGi but this is a topic for another
story (and it is far more complicated to fix).
> Missing Export-Package of packages with "internal" in name
> ----------------------------------------------------------
>
> Key: WICKET-6999
> URL: https://issues.apache.org/jira/browse/WICKET-6999
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 8.14.0, 9.11.0
> Reporter: Daniel Stoch
> Priority: Major
>
> Some packages in Wicket have "internal" word in its name, eg.:
> org.apache.wicket.markup.html.internal
> But they are a part of public API (eg. HtmlHeaderContainer). These packages
> should be exported in MANIFEST.MF file in Export-Package section as in Wicket
> 6.x/7.x.
> I think something was broken in MANIFEST.MF generation, maybe some generator
> plugin (org.apache.felix.maven-bundle-plugin) configuration or version
> change? Packages with "internal" can be by default excluded from
> Export-Package section. But it is not a case in Wicket library.
> Here is excerpt from "Apache Felix Maven Bundle Plugin" documentation:
> {quote}
> <Export-Package> is now assumed to be the set of packages in your local Java
> sources, excluding the default package '.' and any packages containing 'impl'
> or 'internal'. (before version 2 of the bundleplugin it was based on the
> symbolic name)
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
