[ 
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611754#comment-17611754
 ] 

ASF GitHub Bot commented on WICKET-6999:
----------------------------------------

mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263997555

   > > Generally, things like 'internal' are not exported since they are not 
part of a proper API or SPI.
   > 
   > In OSGi world it is indeed. But as I wrote in description in Wicket they 
are part of API (maybe these packages should not have "internal" word in name).
   
   Agreed, Wicket's API+SPI definition and encapsulation could be better. The 
API+SPI should be separated into its own jar and only include interfaces and 
POJO classes. I created https://issues.apache.org/jira/browse/WICKET-6855 to 
open discussion on this, but I didn't articulate the use case in a meaningful 
way.
   




> Missing Export-Package of packages with "internal" in name
> ----------------------------------------------------------
>
>                 Key: WICKET-6999
>                 URL: https://issues.apache.org/jira/browse/WICKET-6999
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.14.0, 9.11.0
>            Reporter: Daniel Stoch
>            Priority: Major
>
> Some packages in Wicket have "internal" word in its name, eg.:
> org.apache.wicket.markup.html.internal
> But they are a part of public API (eg. HtmlHeaderContainer). These packages 
> should be exported in MANIFEST.MF file in Export-Package section as in Wicket 
> 6.x/7.x.
> I think something was broken in MANIFEST.MF generation, maybe some generator 
> plugin (org.apache.felix.maven-bundle-plugin) configuration or version 
> change? Packages with "internal" can be by default excluded from 
> Export-Package section. But it is not a case in Wicket library.
> Here is excerpt from "Apache Felix Maven Bundle Plugin" documentation:
> {quote}
> <Export-Package> is now assumed to be the set of packages in your local Java 
> sources, excluding the default package '.' and any packages containing 'impl' 
> or 'internal'. (before version 2 of the bundleplugin it was based on the 
> symbolic name)
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to