[
https://issues.apache.org/jira/browse/WICKET-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934605#comment-17934605
]
Daniel Stoch edited comment on WICKET-7150 at 3/12/25 5:11 PM:
---------------------------------------------------------------
Probably it would be better to avoid such things like checking existing class
on class path using "Class.forName" (I think it is not a good practice and good
design, but I know that many libraries use such pattern, eg. Spring ;)). Maybe
it would be achieved in another way (some simple extension mechanism,
IInitializer or smth similar) and wicket-native-websocket-javax could register
itself such filter in wicket-native-websocket-core configuration..
was (Author: interface):
Probably it would be better to avoid such things like checking existing class
on class path using "Class.forName" (I think it is not a good practice and good
design, but I know that many libraries use such pattern, eg. Spring ;)). Maybe
it would be achieved in another way (some simple extension mechanism,
IInitializer or smth similar) and wicket-native-websocket-javax should register
itself such filter in wicket-native-websocket-core configuration..
> Cyclic dependency between wicket-native-websocket-core and
> wicket-native-websocket-javax modules
> ------------------------------------------------------------------------------------------------
>
> Key: WICKET-7150
> URL: https://issues.apache.org/jira/browse/WICKET-7150
> Project: Wicket
> Issue Type: Bug
> Components: wicket-native-websocket
> Affects Versions: 9.19.0
> Reporter: Daniel Stoch
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
>
> There is a cyclic dependency issue between the wicket-native-websocket-core
> and wicket-native-websocket-javax modules. The wicket-native-websocket-core
> module has a dependency on the wicket-native-websocket-javax module through
> the WebSocketSettings class, which uses
> Class.forName("org.apache.wicket.protocol.ws.javax.JavaxWebSocketFilter").
> This results in the wicket-native-websocket-core module importing the
> org.apache.wicket.protocol.ws.javax package in its MANIFEST.MF. Since the
> wicket-native-websocket-javax module already depends on the
> wicket-native-websocket-core module, this creates a cyclic dependency between
> these two modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
