[
https://issues.apache.org/jira/browse/WICKET-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935101#comment-17935101
]
Daniel Stoch edited comment on WICKET-7150 at 3/13/25 9:00 AM:
---------------------------------------------------------------
Could you explain a resolution, is it still possible to use another
implementation than JSR-356?
We probably still want to use a dedicated implementation for Jetty, because for
now in our tests this standard JSR-356 from wicket-native-websocket-javax does
not work.
Can this code break such other implementation (based on jetty modules from
previous Wicket versions)?
When should be used:
{code}
filterPrefix.compareAndSet(null, "");
{code}
and when:
{code}
filterPrefix.compareAndSet(null,
RequestCycle.get().getRequest().getFilterPath());
{code}
Probably yes, because we can set custom filterPrefix using setFilterPrefix()
method (if needed)?
PS. What about fix in 9.x?
was (Author: interface):
Could you explain a resolution, is it still possible to use another
implementation than JSR-356?
We probably still want to use a dedicated implementation for Jetty, because for
now in our tests this standard JSR-356 from wicket-native-websocket-javax does
not work.
Can this code break such other implementation (based on jetty modules from
previous Wicket versions)?
When should be used:
{code}
filterPrefix.compareAndSet(null, "");
{code}
and when:
{code}
filterPrefix.compareAndSet(null,
RequestCycle.get().getRequest().getFilterPath());
{code}
PS. What about fix in 9.x?
> Cyclic dependency between wicket-native-websocket-core and
> wicket-native-websocket-javax modules
> ------------------------------------------------------------------------------------------------
>
> Key: WICKET-7150
> URL: https://issues.apache.org/jira/browse/WICKET-7150
> Project: Wicket
> Issue Type: Bug
> Components: wicket-native-websocket
> Affects Versions: 9.19.0
> Reporter: Daniel Stoch
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Fix For: 10.5.0
>
>
> There is a cyclic dependency issue between the wicket-native-websocket-core
> and wicket-native-websocket-javax modules. The wicket-native-websocket-core
> module has a dependency on the wicket-native-websocket-javax module through
> the WebSocketSettings class, which uses
> Class.forName("org.apache.wicket.protocol.ws.javax.JavaxWebSocketFilter").
> This results in the wicket-native-websocket-core module importing the
> org.apache.wicket.protocol.ws.javax package in its MANIFEST.MF. Since the
> wicket-native-websocket-javax module already depends on the
> wicket-native-websocket-core module, this creates a cyclic dependency between
> these two modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
