pedrosans commented on code in PR #1033:
URL: https://github.com/apache/wicket/pull/1033#discussion_r2109800319
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -2059,13 +2020,13 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if
(!isFormComponentVisibleInPage(dependent))
+ else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
> what do you mean by "dirty" data?
Any value returned by dependent formComponent#getInput() or
#getConvertedInput() will have not been validated during the form processing
before the formvalidator check. wicket-core for instance has formvalidators
accessing dependent form component values without checking if they are valid or
not, because it should be safe to assume they are valid inside
IFormValidator#validate execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
