pedrosans commented on code in PR #1033:
URL: https://github.com/apache/wicket/pull/1033#discussion_r2118100546
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -2059,13 +2020,13 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if
(!isFormComponentVisibleInPage(dependent))
+ else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
It would be nice to hear from other devs here, imo to allow disabled
dependent form components inside a formvalidator shouldn't be the default
behavior. But in order to make the form backward compatible with apps being
migrated to wicket 9.x and 10.x, a flag can be provided/proposed and tested
inside the if statement you are proposing to patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
