[
https://issues.apache.org/jira/browse/WICKET-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076447#comment-18076447
]
ASF GitHub Bot commented on WICKET-7179:
----------------------------------------
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3145189270
##########
wicket-core/src/test/js/form.js:
##########
@@ -187,7 +187,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
The idea is that the JS tests could be reused to test with any version of
jQuery.
http://localhost:8080/ajax-tests/test/js/all.html?4.0.0 will test with
jQuery 4.0.0
http://localhost:8080/ajax-tests/test/js/all.html?3.7.1 will test with
jQuery 3.7.1
AFAIR `var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";` is
checking which major version of jQuery is in use. Both 4.x and 3.x should use
`%20` as a space in urls.
> add support for jQuery 4.0.0
> ----------------------------
>
> Key: WICKET-7179
> URL: https://issues.apache.org/jira/browse/WICKET-7179
> Project: Wicket
> Issue Type: Improvement
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
>
> add support for jQuery 4.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
