[ 
https://issues.apache.org/jira/browse/WICKET-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076546#comment-18076546
 ] 

ASF GitHub Bot commented on WICKET-7179:
----------------------------------------

ernestosemedy commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3147051144


##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryMigrateResourceReference.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.resource;
+
+import java.util.List;
+import org.apache.wicket.Application;
+import org.apache.wicket.markup.head.HeaderItem;
+import org.apache.wicket.markup.head.JavaScriptHeaderItem;
+import org.apache.wicket.request.resource.JavaScriptResourceReference;
+import org.apache.wicket.request.resource.ResourceReference;
+
+
+/**
+ * The jQuery migrate library
+ */
+public class JQueryMigrateResourceReference extends JavaScriptResourceReference

Review Comment:
   > I am not sure whether this class should stay. jquery-migrate.js is a 
helper that should be used while migrating jQuery dependant code from 3.x to 
4.x. But once the migration is done it is not needed anymore.
   > 
   > It does not do any harm though.
   
   It is needed by applications wanting to migrate. I.e. I have used it to 
migrate our app to jQuery 4,0 and updated wicket jQuery AJAX file





> add support for jQuery 4.0.0
> ----------------------------
>
>                 Key: WICKET-7179
>                 URL: https://issues.apache.org/jira/browse/WICKET-7179
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Ernesto Reinaldo Barreiro
>            Assignee: Ernesto Reinaldo Barreiro
>            Priority: Major
>
> add support for jQuery 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to