papegaaij commented on code in PR #1595: URL: https://github.com/apache/wicket/pull/1595#discussion_r3989717936
########## wicket-benchmarks/src/main/java/org/apache/wicket/benchmarks/PageSerializationBenchmark.java: ########## @@ -18,14 +18,11 @@ import java.util.concurrent.TimeUnit; -import org.apache.wicket.Component; import org.apache.wicket.MarkupContainer; import org.apache.wicket.markup.IMarkupResourceStreamProvider; import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.html.WebPage; import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.list.ListItem; Review Comment: Formatting and imports is a real issue with these agents, and we have a very simple solution for that at Topicus: make the build fail if done incorrectly. Use use the spotless-maven-plugin for that. You can give it presets and let it fail the build if something is wrong with imports or formatting. It also has a spotless:apply goal that fixes everyting and you can put in the AGENTS.md file that your agent needs to run it after making changes. I think that's something worth adding to Wicket as well, but I'd rather not do it now, because it requires a full reformat of the entire code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
