papegaaij commented on PR #1595: URL: https://github.com/apache/wicket/pull/1595#issuecomment-5639851215
> I'm approving. But this is very difficullt to review. I just made some comments that might make sense or not. It would be nice to port this to 10.x and also host a 10.x. SNAPSHOT somewhere so that we can test this with other applications (e.g. our application). Thanks for all your work! It should not be that hard to backport most of this to 10.x, but I'd rather not ship it in a 10.x release. I'm pretty confident that the code is functionally equivalent, but there may be very subtle changes in behavior. One such change is that behaviors can get different ids. This should normally not make any difference, as long as the id is stable over requests, but someone might depend on these numbers. I can create a branch on 10.x for you to test your application against. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
