reiern70 commented on code in PR #1617:
URL: https://github.com/apache/wicket/pull/1617#discussion_r4159516706
##########
wicket-core-tests/src/test/java/org/apache/wicket/pageStore/AsynchronousPageStoreTest.java:
##########
@@ -271,7 +273,7 @@ public IManageablePage getPage(IPageContext context, int id)
assertEquals(null, asyncPageStore.getPage(context, pageId));
- store.destroy();
+ asyncPageStore.destroy();
semaphore.release();
Review Comment:
Thanks for tracking that down. Both are in now (bce7a1af7b):
`semaphore.release()` comes before `asyncPageStore.destroy()`, and the two
delegates that block on the semaphore restore the interrupt in their catch, so
a saving thread interrupted inside `addPage` exits instead of going back to
`poll()`. The commit message describes it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
