reiern70 commented on code in PR #1617:
URL: https://github.com/apache/wicket/pull/1617#discussion_r4159600027
##########
wicket-core-tests/src/test/java/org/apache/wicket/pageStore/AsynchronousPageStoreTest.java:
##########
@@ -271,7 +273,7 @@ public IManageablePage getPage(IPageContext context, int id)
assertEquals(null, asyncPageStore.getPage(context, pageId));
- store.destroy();
+ asyncPageStore.destroy();
semaphore.release();
Review Comment:
I checked it by running `dontKeepPendingPagesInMapIfSessionExpires` in a
loop in a single JVM (JDK 24, 30 s timeout per iteration):
- With the test as you reviewed it (9658da8944), it hangs on the first
iteration: the test thread is stuck in `Thread.join` at
`AsynchronousPageStore.destroy()`, and the saving thread is back in
`queue.poll(...)` in `PageAddingRunnable.run`, the same thing you saw.
- With bce7a1af7b it passed 500 iterations in a row.
The whole `AsynchronousPageStoreTest` also passes under `mvn verify`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
