danielhumanmod commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1741309025
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergDataHelper.java:
##########
@@ -99,7 +99,9 @@ public class TestIcebergDataHelper {
NestedField.optional(
28, "timestamp_micros_nullable_field",
Types.TimestampType.withZone()),
NestedField.optional(
- 30, "timestamp_local_micros_nullable_field",
Types.TimestampType.withoutZone()));
+ 30, "timestamp_local_micros_nullable_field",
Types.TimestampType.withoutZone()),
+ NestedField.optional(33, "uuid_field", Types.UUIDType.get())
Review Comment:
> Does Iceberg to Delta work as expected? If only Hudi is broken, we can
list that as a limitation and make a test case for Iceberg to Delta for now.
>
> I think we can add in a special case on the assertion for these UUIDs. Are
you thinking of just adding a transform on the field in the dataset?
Thanks for the feedback @the-other-tim-brown , in the latest commit, I have
completed testing for UUID:
1. Add a UUID test case for Iceberg -> Delta for now
2. Add special case on assertion by processing binary UUID into string
before comparison
3. Make "xtableLogicalType" into a constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
