the-other-tim-brown commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1735489121
##########
xtable-core/src/main/java/org/apache/xtable/avro/AvroSchemaConverter.java:
##########
@@ -132,8 +132,13 @@ private InternalSchema toInternalSchema(
break;
}
if (schema.getType() == Schema.Type.FIXED) {
- metadata.put(InternalSchema.MetadataKey.FIXED_BYTES_SIZE,
schema.getFixedSize());
- newDataType = InternalType.FIXED;
+ String xtableLogicalType = schema.getProp("xtableLogicalType");
Review Comment:
Can you put `xtableLogicalType` into a constant that we can reference in the
other files as well?
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaSchemaExtractor.java:
##########
@@ -172,7 +186,11 @@ private InternalSchema toInternalSchema(
type = InternalType.DOUBLE;
break;
case "binary":
- type = InternalType.BYTES;
+ if ("uuid".equals(originalMetadata.getString("xtableLogicalType"))) {
Review Comment:
the `getString` is failing when I run locally. I think there needs to be a
`contains` check first or else you get this `java.util.NoSuchElementException:
key not found: xtableLogicalType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
