the-other-tim-brown commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1838158210


##########
xtable-api/src/main/java/org/apache/xtable/spi/extractor/ExtractFromSource.java:
##########
@@ -47,9 +49,20 @@ public IncrementalTableChanges extractTableChanges(
         commitsBacklog.getCommitsToProcess().stream()
             .map(conversionSource::getTableChangeForCommit)

Review Comment:
   I think that we'll want the identifier on the commit level, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to