the-other-tim-brown commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1845542188


##########
xtable-api/src/main/java/org/apache/xtable/spi/extractor/ExtractFromSource.java:
##########
@@ -47,9 +49,20 @@ public IncrementalTableChanges extractTableChanges(
         commitsBacklog.getCommitsToProcess().stream()
             .map(conversionSource::getTableChangeForCommit)

Review Comment:
   This is true for snapshot sync but with incremental sync, there are multiple 
commits all synced to the target as their own commits. One thing we should 
confirm is whether we are able to track at a per commit level in each target. I 
am unsure if the metadata history is tracked in Iceberg and Delta. It is 
tracked in the Hudi target



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to