vinishjail97 commented on code in PR #591:
URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1889813694
##########
xtable-api/src/main/java/org/apache/xtable/conversion/ConversionConfig.java:
##########
@@ -34,14 +35,21 @@ public class ConversionConfig {
@NonNull SourceTable sourceTable;
// One or more targets to sync the table metadata to
List<TargetTable> targetTables;
+ // Each target table can be synced to multiple target catalogs, this is map
from
+ // targetTableIdentifier to target catalogs.
+ Map<String, List<TargetCatalogConfig>> targetCatalogs;
Review Comment:
It doesn't change the behavior of existing incremental sync, the failure is
returned back as part of this, btw existing XTable users can sync use
incremental sync without configuring source/target catalogs, the existing
RunSync class in utilities or sync function in `ConversionController` is not
changing.
```
// The sync status for each catalog.
List<CatalogSyncStatus> catalogSyncStatusList;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
