the-other-tim-brown commented on code in PR #591: URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1890443132
########## xtable-api/src/main/java/org/apache/xtable/spi/sync/CatalogSyncClient.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.xtable.spi.sync; + +import org.apache.xtable.model.InternalTable; +import org.apache.xtable.model.catalog.CatalogTableIdentifier; + +/** + * An interface for syncing {@link InternalTable} object to {@link TABLE} object defined by the + * catalog. + * + * @param <TABLE> + */ +public interface CatalogSyncClient<TABLE> extends AutoCloseable { + /** + * Returns a unique identifier for the catalog, allows user to sync table to multiple catalogs of + * the same type eg: HMS catalogs with url1, HMS catalog with url2. + */ + String getCatalogName(); + + /** + * Returns the full class name which implements the interface for CatalogSyncClient. + * + * @return catalogImplClassName + */ + String getCatalogImpl(); + + /** Returns the storage location of the table synced to the catalog. */ + String getStorageDescriptorLocation(TABLE table); Review Comment: Should we just call it `getStorageLocation` then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
