the-other-tim-brown commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1956715200
##########
xtable-api/src/test/java/org/apache/xtable/model/metadata/TestTableSyncMetadata.java:
##########
@@ -49,14 +49,17 @@ private static Stream<Arguments> provideMetadataAndJson() {
Instant.parse("2020-07-04T10:15:30.00Z"),
Arrays.asList(
Instant.parse("2020-08-21T11:15:30.00Z"),
- Instant.parse("2024-01-21T12:15:30.00Z"))),
-
"{\"lastInstantSynced\":\"2020-07-04T10:15:30Z\",\"instantsToConsiderForNextSync\":[\"2020-08-21T11:15:30Z\",\"2024-01-21T12:15:30Z\"],\"version\":0}"),
+ Instant.parse("2024-01-21T12:15:30.00Z")),
+ "TEST",
+ "0"),
+
"{\"lastInstantSynced\":\"2020-07-04T10:15:30Z\",\"instantsToConsiderForNextSync\":[\"2020-08-21T11:15:30Z\",\"2024-01-21T12:15:30Z\"],\"version\":0,\"sourceTableFormat\":\"TEST\",\"sourceIdentifier\":\"0\"}"),
Arguments.of(
- TableSyncMetadata.of(Instant.parse("2020-07-04T10:15:30.00Z"),
Collections.emptyList()),
-
"{\"lastInstantSynced\":\"2020-07-04T10:15:30Z\",\"instantsToConsiderForNextSync\":[],\"version\":0}"),
+ TableSyncMetadata.of(
+ Instant.parse("2020-07-04T10:15:30.00Z"),
Collections.emptyList(), "TEST", "0"),
+
"{\"lastInstantSynced\":\"2020-07-04T10:15:30Z\",\"instantsToConsiderForNextSync\":[],\"version\":0,\"sourceTableFormat\":\"TEST\",\"sourceIdentifier\":\"0\"}"),
Arguments.of(
- TableSyncMetadata.of(Instant.parse("2020-07-04T10:15:30.00Z"),
null),
- "{\"lastInstantSynced\":\"2020-07-04T10:15:30Z\",\"version\":0}"));
+ TableSyncMetadata.of(Instant.parse("2020-07-04T10:15:30.00Z"),
null, "TEST", "0"),
+
"{\"lastInstantSynced\":\"2020-07-04T10:15:30Z\",\"version\":0,\"sourceTableFormat\":\"TEST\",\"sourceIdentifier\":\"0\"}"));
Review Comment:
Can we have one test where the fields are not present to ensure that the
parsing will not fail when reading from the previous version's metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
