the-other-tim-brown commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1955453592
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergSync.java:
##########
@@ -244,11 +244,21 @@ public void testCreateSnapshotControlFlow() throws
Exception {
TableFormatSync.getInstance()
.syncSnapshot(Collections.singletonList(conversionTarget), snapshot1);
+ Optional<String> targetIdentifier1 =
+
conversionTarget.getTargetCommitIdentifier(snapshot1.getSourceIdentifier());
validateIcebergTable(tableName, table1, Sets.newHashSet(dataFile1,
dataFile2), null);
+ assertTrue(targetIdentifier1.isPresent());
Review Comment:
Can we assert on the content of the Optional?
##########
xtable-core/src/test/java/org/apache/xtable/hudi/ITHudiConversionTarget.java:
##########
@@ -367,6 +382,20 @@ CONTEXT,
getHoodieWriteConfig(metaClient).getMetadataConfig(), tableBasePath, tr
assertColStats(hoodieBackedTableMetadata, partitionPath, fileName3);
assertColStats(hoodieBackedTableMetadata, partitionPath, fileName4);
}
+ Optional<String> targetIdentifier3 =
targetClient.getTargetCommitIdentifier("2", metaClient);
+ assertTrue(targetIdentifier3.isPresent());
Review Comment:
Can we assert on the content of the Optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
