ashvina commented on code in PR #653:
URL: https://github.com/apache/incubator-xtable/pull/653#discussion_r1960824029
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/FilesDiff.java:
##########
@@ -92,12 +92,12 @@ public static <L, P> FilesDiff<L, P> findNewAndRemovedFiles(
* @param <P> the type of the previous files
* @return the set of files that are added
*/
- public static <P> FilesDiff<InternalDataFile, P> findNewAndRemovedFiles(
+ public static <P> FilesDiff<? extends InternalBaseFile, P>
findNewAndRemovedFiles(
Review Comment:
The verbosity of generics doesn't seem like a problem to me; verbosity is
something unavoidable in Java. Also, I don't think that would be the good use
of an interface and it wouldn't be consistent. That said, there were places
where the base class was sufficient, so I used it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
