the-other-tim-brown commented on code in PR #653:
URL: https://github.com/apache/incubator-xtable/pull/653#discussion_r1963290207
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/FilesDiff.java:
##########
@@ -92,12 +92,12 @@ public static <L, P> FilesDiff<L, P> findNewAndRemovedFiles(
* @param <P> the type of the previous files
* @return the set of files that are added
*/
- public static <P> FilesDiff<InternalDataFile, P> findNewAndRemovedFiles(
+ public static <P> FilesDiff<? extends InternalBaseFile, P>
findNewAndRemovedFiles(
Review Comment:
I think that this is not a reason to close the PR. I was just trying to
understand where you were coming from with your approach so I could try to see
where things were going in general with how we can handle the different types
of files in the targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
