the-other-tim-brown commented on code in PR #649:
URL: https://github.com/apache/incubator-xtable/pull/649#discussion_r1961955079
##########
xtable-aws/src/test/java/org/apache/xtable/glue/TestGlueCatalogSyncClient.java:
##########
@@ -75,7 +76,12 @@ public class TestGlueCatalogSyncClient extends
GlueCatalogSyncTestBase {
private GlueCatalogSyncClient createGlueCatalogSyncClient() {
return new GlueCatalogSyncClient(
- catalogConfig, testConfiguration, mockGlueCatalogConfig,
mockGlueClient, mockTableBuilder);
+ catalogConfig,
+ testConfiguration,
+ mockGlueCatalogConfig,
+ mockGlueClient,
+ mockTableBuilder,
+ Optional.empty());
Review Comment:
Similar to the Hive PR, let's add similar parameterized testing around this
option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
