vamsikarnika commented on code in PR #649:
URL: https://github.com/apache/incubator-xtable/pull/649#discussion_r1962884997
##########
xtable-hive-metastore/src/main/java/org/apache/xtable/hms/table/HudiHMSCatalogTableBuilder.java:
##########
@@ -143,20 +144,6 @@ public Table getUpdateTableRequest(
return hmsTable;
}
- private Map<String, String> getTableProperties(InternalTable table,
InternalSchema schema) {
- List<String> partitionFields =
- table.getPartitioningFields().stream()
- .map(field -> field.getSourceField().getName())
- .collect(Collectors.toList());
- Map<String, String> tableProperties = new HashMap<>();
- tableProperties.put(HUDI_METADATA_CONFIG, "true");
- Map<String, String> sparkTableProperties =
- tablePropertiesExtractor.getSparkTableProperties(
- partitionFields, "", hmsCatalogConfig.getSchemaLengthThreshold(),
schema);
- tableProperties.putAll(sparkTableProperties);
- return tableProperties;
- }
-
Review Comment:
Moved this code to HudiCatalogTablePropertiesExtractor since this was common
to Glue as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
