ashvina commented on code in PR #662:
URL: https://github.com/apache/incubator-xtable/pull/662#discussion_r1984122322
##########
xtable-core/src/test/java/org/apache/xtable/hudi/TestBaseFileUpdatesExtractor.java:
##########
@@ -135,7 +136,7 @@ void convertDiff() {
expectedPartitionToReplacedFileIds.put(
partitionPath1, Arrays.asList(fileName3, fileIdForFile4));
expectedPartitionToReplacedFileIds.put(partitionPath2,
Collections.singletonList(fileName5));
- assertEquals(
+ assertEqualsIgnoreOrder(
expectedPartitionToReplacedFileIds,
replaceMetadata.getPartitionToReplacedFileIds());
Review Comment:
Hi @vinishjail97 . I didn't understand. Have you tried this change, does it
compile?
1. `expectedPartitionToReplacedFileIds` is a `HashMap` which cannnot be used
to initialize a `HashSet`
2. The order mismatch happens in the `values` of the HashMaps, where the
`values` are `List`s. The tests fails when the values in the lists are out of
order. Please see the example in the bug report for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
