vinishjail97 commented on code in PR #662:
URL: https://github.com/apache/incubator-xtable/pull/662#discussion_r1984146003
##########
xtable-core/src/test/java/org/apache/xtable/hudi/TestBaseFileUpdatesExtractor.java:
##########
@@ -135,7 +136,7 @@ void convertDiff() {
expectedPartitionToReplacedFileIds.put(
partitionPath1, Arrays.asList(fileName3, fileIdForFile4));
expectedPartitionToReplacedFileIds.put(partitionPath2,
Collections.singletonList(fileName5));
- assertEquals(
+ assertEqualsIgnoreOrder(
expectedPartitionToReplacedFileIds,
replaceMetadata.getPartitionToReplacedFileIds());
Review Comment:
My bad didn't see it was `Map<String, List<String>>`, change LGTM.
`Hudi does not depend on the order of the files in the lists?`
Yes it does not depend on order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
