ashvina commented on code in PR #663:
URL: https://github.com/apache/incubator-xtable/pull/663#discussion_r1987941597
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -247,7 +247,7 @@ public boolean isIncrementalSyncSafeFrom(Instant instant) {
long timeInMillis = instant.toEpochMilli();
Table iceTable = getSourceTable();
boolean doesInstantOfAgeExists = false;
- Long targetSnapshotId = null;
Review Comment:
Thanks for the PR @the-other-tim-brown. This fix seems to be addressing
another issue. I will let @brishi19791, who reported the original issue, to
confirm.
My understanding is that iceberg api may not return ordered snapshots as the
spec does not mandate it. Also, the snapshot order seems to engine dependedent.
Whereas the while loops in `isIncrementalSyncSafeFrom` is order sensitive, it
may break prematurely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
