ashvina commented on code in PR #663:
URL: https://github.com/apache/incubator-xtable/pull/663#discussion_r1987946938
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -247,7 +247,7 @@ public boolean isIncrementalSyncSafeFrom(Instant instant) {
long timeInMillis = instant.toEpochMilli();
Table iceTable = getSourceTable();
boolean doesInstantOfAgeExists = false;
- Long targetSnapshotId = null;
Review Comment:
If my observation is correct, we have two options. 1) @brishi19791 creates
another PR with his fix and we merge both these, or 2) merge @brishi19791's PR
in this branch and merge the two fixes together. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
