the-other-tim-brown commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2224165190
##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -141,7 +140,7 @@ private static Stream<Arguments>
testCasesWithPartitioningAndSyncModes() {
private static Stream<Arguments>
generateTestParametersForFormatsSyncModesAndPartitioning() {
List<Arguments> arguments = new ArrayList<>();
- for (String sourceTableFormat : Arrays.asList(HUDI, DELTA, ICEBERG)) {
+ for (String sourceTableFormat : Arrays.asList(HUDI, DELTA, ICEBERG,
PARQUET)) {
Review Comment:
This will likely cause some issues since we don't have a concept for updates
or deletes in the parquet source. It is assumed to be append-only. We can
instead setup a new test in this class that creates parquet tables, converts
them to all 3 other table formats, and validates the data using the existing
helpers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
