the-other-tim-brown commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2236767433


##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -141,7 +140,7 @@ private static Stream<Arguments> 
testCasesWithPartitioningAndSyncModes() {
 
   private static Stream<Arguments> 
generateTestParametersForFormatsSyncModesAndPartitioning() {
     List<Arguments> arguments = new ArrayList<>();
-    for (String sourceTableFormat : Arrays.asList(HUDI, DELTA, ICEBERG)) {
+    for (String sourceTableFormat : Arrays.asList(HUDI, DELTA, ICEBERG, 
PARQUET)) {

Review Comment:
   Yes we can use the spark session and your understanding of the methods is 
correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to