mao-liu commented on code in PR #767:
URL: https://github.com/apache/incubator-xtable/pull/767#discussion_r2608219177
##########
xtable-core/src/main/java/org/apache/xtable/paimon/PaimonDataFileExtractor.java:
##########
@@ -78,10 +93,154 @@ private String toFullPhysicalPath(FileStoreTable table,
ManifestEntry entry) {
}
}
- private List<ColumnStat> toColumnStats(DataFileMeta file) {
- // TODO: Implement logic to extract column stats from the file meta
- // https://github.com/apache/incubator-xtable/issues/755
- return Collections.emptyList();
+ private List<ColumnStat> toColumnStats(DataFileMeta file, InternalSchema
internalSchema) {
Review Comment:
Will do, thanks for the early review @the-other-tim-brown !
I do wonder though, if it is even possible to have Paimon as a target...
Paimon has a pretty unique file layout, and might not be as easily "tricked" as
other formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
