the-other-tim-brown commented on code in PR #767:
URL: https://github.com/apache/incubator-xtable/pull/767#discussion_r2610802702
##########
xtable-core/src/main/java/org/apache/xtable/paimon/PaimonDataFileExtractor.java:
##########
@@ -78,10 +93,154 @@ private String toFullPhysicalPath(FileStoreTable table,
ManifestEntry entry) {
}
}
- private List<ColumnStat> toColumnStats(DataFileMeta file) {
- // TODO: Implement logic to extract column stats from the file meta
- // https://github.com/apache/incubator-xtable/issues/755
- return Collections.emptyList();
+ private List<ColumnStat> toColumnStats(DataFileMeta file, InternalSchema
internalSchema) {
Review Comment:
I don't know enough about Paimon to say. Hudi also has a unique native
layout structure to allow for update heavy workloads though and we were able to
make this work.
Mainly we do this separation to keep the logic isolated though. As not
necessarily relevant to Paimon, but if a table format changes how they
represent stats in a new version, we can plug in the appropriate converter
based on the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
