the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2633294861
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergSchemaExtractor.java:
##########
@@ -57,14 +58,64 @@ public class IcebergSchemaExtractor {
private static final String MAP_KEY_FIELD_NAME = "key";
private static final String MAP_VALUE_FIELD_NAME = "value";
private static final String LIST_ELEMENT_FIELD_NAME = "element";
+ @Getter private final Map<Integer, String> idToStorageName = new HashMap<>();
Review Comment:
@xr-chen This adds state to the class so we have to decide if we want to
make an instance of this class per conversion or remove this state.
Removing the state would require you to return the map as part of the
response for the `toIceberg`.
I don't have a strong opinion either way, but I would prefer that over the
`clear` call in the `toIceberg` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
