the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2633408323
##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -746,6 +746,29 @@ public void testIcebergCorruptedSnapshotRecovery() throws
Exception {
}
}
+ @Test
+ public void testColumnMappingEnabledDeltaToIceberg() {
Review Comment:
We already have some helpers for this. Earlier in this test class you will
see a [test
case](https://github.com/apache/incubator-xtable/blob/main/xtable-core/src/test/java/org/apache/xtable/ITConversionController.java#L270)
that uses
[GenericTable.getInstanceWithAdditionalColumns](https://github.com/apache/incubator-xtable/blob/main/xtable-core/src/test/java/org/apache/xtable/GenericTable.java#L103).
This has some helpers for creating the evolved Delta table schema under the
hood that you should be able to build off of.
And yes, just inserting or updating some more records is fine. I just want
to ensure there isn't some unexpected side-effect when we set this table
property multiple times for Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
